Is there a better way to store calibration values?

[bschriek]

<16F15223.H> CCS compiler 5.121

I use the following code to read and write calibration values to the memory of my PIC's for years. Although it works fine can somebody tell me if a better solution is available for the modern pic's like the 16F15223?


//---------------Configuration-----------------//
#define HEF 0X0780
#ROM int16 HEF = {160,160}

struct twobytes
{
int8 l;
int8 h;
};

union prog_mem
{
int16 word;
struct twobytes b;
};


//-----------------Main loop-------------------//
struct {
union prog_mem I_cal_hef_24V;
union prog_mem U_cal_hef_24V;
}


//--------Read calibration values from memory--------//
read_program_memory(HEF,&values,2);
I_cal_24V = values.I_cal_hef_24V.b.l;
U_cal_24V = values.U_cal_hef_24V.b.l;

//--------Write calibration values to memory--------//
values.I_cal_hef_24V.b.l = I_sense_24V;
values.U_cal_hef_24V.b.l = U_sense_24V;
write_program_memory(HEF,&values,2);


Sorry for this question but I'm a hardware engineer.......

[newguy]

Not really. Two things: the address of the high endurance flash should be available using the getenv feature so that you don't have to look it up yourself. Second, I always guard writes to memories that are either slow or can wear out (or both). I always read the contents of the memory first and only write if the value is different than what I intend to write.

Other than those minor nit picks, you're doing it right.