for cicle doesn't work and binary parameter using variable

[j_gatz]

hi, im new to ccs, im trying to get the logic values from portb through a 4 buttons switch to make a binary number, im using these values to turn on some leds in a display of 7 segments using as output portd, the lit leds represent the number in hexadecimal. The thing is I need to do it with logical operations like OR AND.

[Ttelmah]

As coded if any statement is TRUE, you will get a result of 'TRUE' (1).
You don't show how you have coded the pins. Presumably #bit
statements?.

I'd suggest you change the approach. If you have four buttons, then
all you need is an array of the bit patterns you want for the LED's.
16 entries.

Then just read the whole of port B. Take the low 4 bits.
So:

val=input_b() & 0xF; //val is now the low four bits of b.

Then output this to the led's:

array[val] is then the value you want to sent to the LED's.

Now you don't say whether your LED's are wired to come on with a 0,
or a 1?.

Your current posted code, for the 16 possible input combinations gives:

[j_gatz]

thank you so much, building a binary number worked, I didn't know that output function could receive decimals, and thanks for the advice, certainly an array would be simpler but this time I was asked for doing it with logical operations.
so i convert every logic operation into a binary expression which essentially is a decimal expression.

by the way i don't really understand why the for cycle didn't work, I tried to use it to name each pin input but didn't work, I had to make it manually. so I couldnt use for cycle in any way.

[Ttelmah]

Several bits to possibly why the loop didn't work.

First, what chip???. The actual binary values for pins depend totally on this.

Second, what compiler version???. This latter is vital. The early compilers
(V3 and before) would not accept a variable to access a pin. In the forum,
dating from these early compilers, is a function from PCM_Programmer
to give variable access.

One other thought is that instead of the array you currently use, you could
use a structure containing these elements as bit fields. Have this in a
union with a byte, and the byte is the required result without the overhead
of the multiplication.

[rjenkinsgb]

To clarify the problem with your first try, the "PIN_B0" etc. references are just numbers, internally - you can see them in each device header file.


To use those to access the device ports/pins, you have to use such as
input(PIN_B0);
or
output_bit(PIN_C2, HIGH);